Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust to ocis v5.0.0-alpha.4 #440

Merged
merged 2 commits into from
Nov 30, 2023
Merged

chore: adjust to ocis v5.0.0-alpha.4 #440

merged 2 commits into from
Nov 30, 2023

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Nov 30, 2023

Description

Updates ocis to v5.0.0-alpha.4 and adds the 2 new web embed mode config vars, see owncloud/ocis#7852

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@kulmann kulmann self-assigned this Nov 30, 2023
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

{{- if .Values.services.web.config.embed.delegateAuthentication }}
- name: WEB_OPTION_EMBED_DELEGATE_AUTHENTICATION
value: {{ .Values.services.web.config.embed.delegateAuthentication | quote }}
{{- end}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{- end}}
{{- end }}

@wkloucek wkloucek merged commit da35de0 into next Nov 30, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the adjust-embed-config branch November 30, 2023 13:30
@wkloucek wkloucek mentioned this pull request Mar 18, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants