-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oCIS as of 5.0.0-alpha.1 #419
Conversation
You are quicker than myself. I wanted to open a PR on myself. It is With both variables you can control it and the naming is clearer. We agreed that there is no use case for only enforcing it for "readable" public shares. |
I looked at the changelog: https://github.com/owncloud/ocis/blob/a15fe45d6ac45a4f7ee8e76ada09fa6a2d516ebb/changelog/unreleased/readable-share-enforce-password.md This seems outdated then!? |
Yes, i need to fix it. |
@micbar why needs OCIS_SHARING_PUBLIC_WRITEABLE_SHARE_MUST_HAVE_PASSWORD to be configured for sharing and frontend service, while OCIS_SHARING_PUBLIC_SHARE_MUST_HAVE_PASSWORD is only available for the frontend service? 🤔 |
I updated the PR by assuming there will also be a |
Fix for the changelog owncloud/ocis#7609 |
I updated this PR to 5.0.0-alpha.1, please review :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo not critical
Co-authored-by: kobergj <[email protected]>
Description
oCIS as of 5.0.0-alpha.1 + add some configuration options
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
make docs
) and committed