Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oCIS as of 5.0.0-alpha.1 #419

Merged
merged 5 commits into from
Nov 6, 2023
Merged

oCIS as of 5.0.0-alpha.1 #419

merged 5 commits into from
Nov 6, 2023

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Oct 27, 2023

Description

oCIS as of 5.0.0-alpha.1 + add some configuration options

Related Issue

Motivation and Context

How Has This Been Tested?

  • I ran the office integration deployment example in minikube and edited some files with Collabora / OnlyOffice

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@micbar
Copy link
Contributor

micbar commented Oct 27, 2023

You are quicker than myself. I wanted to open a PR on myself.

It is FRONTEND_OCS_PUBLIC_SHARE_MUST_HAVE_PASSWORD which applies to all public shares.

With both variables you can control it and the naming is clearer. We agreed that there is no use case for only enforcing it for "readable" public shares.

@wkloucek
Copy link
Contributor Author

wkloucek commented Oct 27, 2023

It is FRONTEND_OCS_PUBLIC_SHARE_MUST_HAVE_PASSWORD which applies to all public shares.

With both variables you can control it and the naming is clearer. We agreed that there is no use case for only enforcing it for "readable" public shares.

I looked at the changelog: https://github.com/owncloud/ocis/blob/a15fe45d6ac45a4f7ee8e76ada09fa6a2d516ebb/changelog/unreleased/readable-share-enforce-password.md

This seems outdated then!?

@micbar
Copy link
Contributor

micbar commented Oct 27, 2023

This seems outdated then!?

Yes, i need to fix it.

@wkloucek
Copy link
Contributor Author

@micbar why needs OCIS_SHARING_PUBLIC_WRITEABLE_SHARE_MUST_HAVE_PASSWORD to be configured for sharing and frontend service, while OCIS_SHARING_PUBLIC_SHARE_MUST_HAVE_PASSWORD is only available for the frontend service? 🤔

@wkloucek
Copy link
Contributor Author

I updated the PR by assuming there will also be a SHARING_PUBLIC_SHARE_MUST_HAVE_PASSWORD setting.

@micbar
Copy link
Contributor

micbar commented Oct 27, 2023

Fix for the changelog owncloud/ocis#7609

@wkloucek wkloucek marked this pull request as draft November 2, 2023 06:46
@wkloucek wkloucek changed the title oCIS as of 27th October 2023 oCIS as of 5.0.0-alpha.1 Nov 2, 2023
@wkloucek wkloucek marked this pull request as ready for review November 2, 2023 07:12
@wkloucek wkloucek requested a review from micbar November 2, 2023 07:12
@wkloucek
Copy link
Contributor Author

wkloucek commented Nov 2, 2023

I updated this PR to 5.0.0-alpha.1, please review :-)

Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo not critical

charts/ocis/templates/sharing/deployment.yaml Outdated Show resolved Hide resolved
@wkloucek wkloucek merged commit c9d6e87 into next Nov 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the update-ocis-on-next-27-oct branch November 6, 2023 12:00
@wkloucek wkloucek mentioned this pull request Mar 18, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants