mail config #414
Merged
mail config #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
case0sh
force-pushed
the
mail-config
branch
2 times, most recently
from
8b0630d to
94748cb
Compare
wkloucek
requested changes
Oct 20, 2023
There was a problem hiding this comment.
Did you try this change with the ocis-mail deployment example. When I run it, the notifications service is in a restart loop with following error:
notifications-755d65b87b-8twwr notifications unknown value 'auto' for 'smtp_encryption' in service notifications. Allowed values are 'starttls', 'ssltls' or 'none'
Could you please check why auto is not a accepted value?
charts/ocis/values.yaml
Outdated
| # -- Encryption method for the SMTP communication. Possible values are ‘starttls’, ‘ssl’, ‘ssltls’, ‘tls’ and ‘none’. | ||
| encryption: none | ||
| # -- Encryption method for the SMTP communication. Possible values are ‘starttls’, ‘ssltls’, ‘auto’ and ‘none’. | ||
| # -- Values 'ssl' and 'tls' are deprecated and will be removed in version "6.0.0". Use 'starttls' instead of 'tls' and 'ssltls' instead of 'ssl'. |
There was a problem hiding this comment.
will be removed in version "6.0.0"
I think this leaves some rooms for confusion, because this Helm Chart also has a version (that is far away from version 6) but we could improve it like this: will be removed in oCIS release 6.0.0
This was referenced Oct 20, 2023
|
This was nonsense, please see @rhafer's review. |
rhafer
suggested changes
Oct 25, 2023
rhafer
approved these changes
Oct 25, 2023
wkloucek
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the default value for encryption, also indicated which values are outdated and will be removed in version "6.0.0"
Related Issue
nextbranch #409How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
make docs) and committed