language conf #408
Merged
language conf #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2023
wkloucek
requested changes
Oct 17, 2023
wkloucek
requested changes
Oct 18, 2023
There was a problem hiding this comment.
From what I see in owncloud/ocis#7465 (comment) owncloud/ocis#7479, OCIS_DEFAULT_LANGUAGE needs to be added to not only the settings service
case0sh
force-pushed
the
language-conf
branch
from
271daed to
9d72bd7
Compare
wkloucek
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change environment name for default language option
Related Issue
How Has This Been Tested?
test environment: k8s, minikube, helm chart
test case 1: set "features.language.default" env to "de"
login as UserA and trigger a mail notification for userB by sharing a file
Types of changes
Checklist:
make docs) and committed