Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings default lang #407

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Settings default lang #407

merged 1 commit into from
Oct 17, 2023

Conversation

case0sh
Copy link
Contributor

@case0sh case0sh commented Oct 11, 2023

Description

Settings for default language

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@case0sh case0sh changed the base branch from master to next October 11, 2023 12:40
@case0sh case0sh marked this pull request as ready for review October 11, 2023 12:41
@case0sh case0sh requested a review from wkloucek October 11, 2023 12:41
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with following setup:

diff --git a/deployments/ocis-mail/helmfile.yaml b/deployments/ocis-mail/helmfile.yaml
index e551f26..a60ee54 100644
--- a/deployments/ocis-mail/helmfile.yaml
+++ b/deployments/ocis-mail/helmfile.yaml
@@ -44,6 +44,8 @@ releases:
               sender: "ownCloud <[email protected]>"
             branding:
               enabled: false # you can set this to true if you first run `kubectl -n ocis apply -f mail-templates.yaml`
+          language:
+            default: "de"
 
       - services:
           idm:

Works fine.

@wkloucek wkloucek merged commit 5b846d0 into next Oct 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the default-lang branch October 17, 2023 08:17
@wkloucek wkloucek mentioned this pull request Mar 18, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support SETTINGS_DEFAULT_LANGUAGE
2 participants