Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hostaliases #398

Merged
merged 2 commits into from
Sep 18, 2023
Merged

add hostaliases #398

merged 2 commits into from
Sep 18, 2023

Conversation

case0sh
Copy link
Contributor

@case0sh case0sh commented Sep 18, 2023 •
edited
Loading

Description

add HostAliases to deployments is required for minikube mac setup

Related Issue

How Has This Been Tested?

  • test environment: minikube helmfile
  • test case 1:

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation generated (make docs) and committed
  • Documentation ticket raised:
  • Documentation PR created:

@case0sh case0sh requested a review from wkloucek September 18, 2023 08:56
@case0sh case0sh marked this pull request as ready for review September 18, 2023 08:56
@wkloucek
Copy link
Contributor

@case0sh I think we should add the hostalias to all pods. This would make this setting more versatile.

@case0sh case0sh force-pushed the hostaliases branch 2 times, most recently from 12c101a to 914276f Compare September 18, 2023 12:29
@case0sh
Copy link
Contributor Author

case0sh commented Sep 18, 2023

we have to wait for the webFinger.

@case0sh case0sh force-pushed the hostaliases branch 2 times, most recently from f5b7067 to 9936696 Compare September 18, 2023 12:42
@wkloucek wkloucek merged commit 0237eb4 into master Sep 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the hostaliases branch September 18, 2023 13:00
@mmattel mmattel mentioned this pull request Oct 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkloucek wkloucek wkloucek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@case0sh @wkloucek