-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mail template configuration #330
Conversation
I ran into this:
Looks like the current implementation doesn't like Kubernetes ConfigMaps, because the template path looks like this when mounting these files as configmap:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we might need a new issue for the point I highlight in the comment.
# -- Reference to an existing SMTP email server settings secret (see ref:Secrets#secrets). Not used if `features.emailNotifications.enabled` equals `false`. | ||
# -- Reference to an existing SMTP email server settings secret (see ref:Secrets#secrets). | ||
# Not used if `features.emailNotifications.enabled` equals `false`. | ||
# Not used if `features.emailNotifications.smtp.authentication` equals `none`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this description needs some more information about the keys we expect in the secret. Not especially related to this PR this was already missing before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, the secret section https://doc.owncloud.com/ocis/next/deployment/container/orchestration/orchestration.html#secrets needs a complete rework since we switched to automatically creating secrets. Tracking issue: #367
Description
adds the option to configure mail templates. On the way it adds an example deployment with mailbucket to test mail sending functionality.
Related Issue
appVersion
inChart.yaml
pendingMotivation and Context
allow to change mail templates
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
make docs
) and committed