Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- add support for Kubernetes sub versions #147

Merged
merged 3 commits into from
Mar 14, 2023
Merged

- add support for Kubernetes sub versions #147

merged 3 commits into from
Mar 14, 2023

Conversation

d7oc
Copy link
Contributor

@d7oc d7oc commented Mar 13, 2023

Description

The change adds support for Kubernetes sub versions. Currently a Kubernetes version like v1.23.4-r0-CCE22.5.1 will not be detect although it's in the 1.24 range specified.

Related Issue

None

Motivation and Context

Something users run Kubernetes systems with identify themselves with a subversion. Currently this will not work properly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

@d7oc d7oc added the Status:Needs-Review Needs review from a maintainer label Mar 13, 2023
@d7oc d7oc requested a review from wkloucek March 13, 2023 16:59
@wkloucek wkloucek requested a review from mmattel March 14, 2023 08:04
@wkloucek
Copy link
Contributor

@mmattel Looks like we should add this to the documentation when merged.

@mmattel
Copy link
Contributor

mmattel commented Mar 14, 2023

I will adapt the documentation that it includes subversions - when merged.

@d7oc for merging, pls solve the conflict.

@wkloucek when merged, does that update the adoc table automatically or does this need manual maintenance so that it shows up in the docs?

@wkloucek
Copy link
Contributor

@wkloucek when merged, does that update the adoc table automatically or does this need manual maintenance so that it shows up in the docs?

Thanks for the reminder, I generated the docs. It will only apply for the "latest" helm chart, so no backport to "0.1.0" because we will do a new chart release when oCIS 3.0.0 support reaches a stable state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants