Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails hardening #570

Closed
Tracked by #634 ...
wkloucek opened this issue May 16, 2024 · 5 comments · Fixed by #642
Closed
Tracked by #634 ...

Thumbnails hardening #570

wkloucek opened this issue May 16, 2024 · 5 comments · Fixed by #642
Labels

Comments

@wkloucek
Copy link
Contributor

wkloucek commented May 16, 2024

expose THUMBNAILS_MAX_CONCURRENT_REQUESTS and THUMBNAILS_MAX_INPUT_IMAGE_FILE_SIZE as a configuration when available

@wkloucek
Copy link
Contributor Author

wkloucek commented May 28, 2024

THUMBNAILS_MAX_CONCURRENT_REQUESTS was also back ported to stable-5.0 -> owncloud/ocis#9252

@d7oc d7oc mentioned this issue Jul 10, 2024
6 tasks
@wkloucek
Copy link
Contributor Author

@dschmidt is this something you could have a look at, too?

@dschmidt
Copy link
Member

If it's just adding those settings to the thumbnails service, I can probably manage to do that, yeah

@case0sh case0sh mentioned this issue Jul 15, 2024
11 tasks
@wkloucek
Copy link
Contributor Author

@d7oc During #654, I looked at it and oCIS 5.0.6 supports now THUMBNAILS_MAX_CONCURRENT_REQUESTS but not THUMBNAILS_MAX_INPUT_IMAGE_FILE_SIZE, so we could only port half of #642. Should I do it anyways?

@d7oc
Copy link
Contributor

d7oc commented Jul 23, 2024

Better some protection than nothing I would say.

wkloucek added a commit to wkloucek/ocis-charts that referenced this issue Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants