The user is set on the login screen if transmitted from the client #67
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
===========================================
- Coverage 84.33% 83.93% -0.4%
- Complexity 179 180 +1
===========================================
Files 20 20
Lines 632 635 +3
===========================================
Hits 533 533
- Misses 99 102 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I'm still getting a redirection and a code with this PR when logged in as a different user and doing the switch via <server>/index.php/apps/oauth2/logout?user=<user>&requesttoken=<token>&response_type=code&client_id=<client_id>&redirect_uri=<redirect_url> (same as described in #66 (comment)) I guess it's in the PR's scope, no?
js/login.js
Outdated
| var user = $("data[key='oauth2']").attr('user'); | ||
| if (user) { | ||
| $('#password').val(''); | ||
| $('#user').val(user); |
There was a problem hiding this comment.
@DeepDiver1975 what do you think of including:
$('#user').prop('readonly', true);
... so we force the user to login as the original user?
We'll loose focus on the login form though; password should receive it now for better UX I'm guessing.
There was a problem hiding this comment.
I'm still getting a redirection and a code with this PR when logged in as a different user and doing the switch via /index.php/apps/oauth2/logout?user=&requesttoken=&response_type=code&client_id=<client_id>&redirect_uri=<redirect_url> (same as described in #66 (comment)) I guess it's in the PR's scope, no?
I still need to work on this ... maybe in scope .... lets see ...
DeepDiver1975
force-pushed
the
set-user-on-login
branch
from
256429e to
75e88e6
Compare
both taken care of .... |
|
Very nice! Working flawlessly together with owncloud/core#28511 👍 @DeepDiver1975 move #67 (review) to a different issue and merge here? |
yes please - I need to understand this better ... THX |
Done in #68. Hope it helps! |
fixes #66