do not show hidden shares #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
commented
Jan 17, 2024
individual-it
requested review from
amrita-shrestha,
S-Panta and
nirajacharya2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shares that are set to
hiddenin the ocis webUI, should not be listed in moodle etherfixes #73
The information about if a share is hidden or not is provided by the
sharedWithMeendpoint of ocis.Using the id of the resource we can associate the share from
sharedWithMewith the resource from WebDAV, if that share is set to be hidden, we simply skip it.While testing this: