Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize drone file #112

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Optimize drone file #112

merged 3 commits into from
Apr 30, 2024

Conversation

amrita-shrestha
Copy link
Contributor

  • remove unnecessary code
  • add starlark linter
  • fix starlark styling

@amrita-shrestha amrita-shrestha self-assigned this Apr 30, 2024
@amrita-shrestha amrita-shrestha force-pushed the add-starlark-linter branch 5 times, most recently from 45ea3f2 to a467b27 Compare April 30, 2024 08:47
@amrita-shrestha amrita-shrestha changed the title Update drone file Optimize drone file Apr 30, 2024
@amrita-shrestha amrita-shrestha marked this pull request as ready for review April 30, 2024 09:08
phil-davis
phil-davis approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit 526d99e into main Apr 30, 2024
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-starlark-linter branch April 30, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it

@saw-jan saw-jan Awaiting requested review from saw-jan

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@amrita-shrestha amrita-shrestha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrita-shrestha @phil-davis