Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding test for refresh button #106

Merged
merged 1 commit into from
Apr 24, 2024
Merged

adding test for refresh button #106

merged 1 commit into from
Apr 24, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Apr 23, 2024

adding test for refresh button

related issue: #17 (comment)

@nirajacharya2 nirajacharya2 self-assigned this Apr 23, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Apr 23, 2024
2 tasks
@nirajacharya2 nirajacharya2 marked this pull request as ready for review April 23, 2024 05:40
tests/behat/uploadFileToMoodle.feature Outdated Show resolved Hide resolved
@nirajacharya2 nirajacharya2 force-pushed the test-refresh-button branch 3 times, most recently from 0299821 to 309a9c6 Compare April 24, 2024 03:21
@nirajacharya2 nirajacharya2 force-pushed the test-refresh-button branch 2 times, most recently from d6935d1 to 94628be Compare April 24, 2024 04:20
@nirajacharya2 nirajacharya2 force-pushed the test-refresh-button branch 3 times, most recently from 12bb75d to 10a7415 Compare April 24, 2024 07:17
@nirajacharya2 nirajacharya2 force-pushed the test-refresh-button branch 2 times, most recently from 379c6c3 to 1e82553 Compare April 24, 2024 08:57
tests/behat/uploadFileToMoodle.feature Outdated Show resolved Hide resolved
tests/behat/uploadFileToMoodle.feature Outdated Show resolved Hide resolved
@phil-davis phil-davis self-requested a review April 24, 2024 10:05
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Then I should not see "testfile.txt"
But I should see "testfile.txt" after refreshing the file-picker

Scenario: click refresh button to get latest resource on Project drive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is a sequence of two "tests". But the 2nd part follows directly after the first part, and depends on it anyway.
It could be split into 2 scenarios, but that would use up test run time without a real benefit. So, IMO, this is OK.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@individual-it individual-it merged commit e0d61a9 into main Apr 24, 2024
9 checks passed
@delete-merged-branch delete-merged-branch bot deleted the test-refresh-button branch April 24, 2024 11:00
S-Panta pushed a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants