Fix code generation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
fix-code-generation
branch
from
8266948 to
686d9c0
Compare
refs
approved these changes
May 12, 2021
|
I copy&pasted the spec into swagger editor, seems fine so far. |
|
CI validator is also green. |
|
Continuing with this code generation library, we'd need to also update: https://github.com/owncloud/open-graph-api-go. Could you also rename the file to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPI v3.1 seems to alow $ref siblings, which allows us to generate actually usable code. So we dropped the anyOf "workaround".
To validate the 3.1 spec the openapi-generator in #9083 tracks the swagger-api/swagger-parser #1531 implementation for it.