fix the warning in main thread

[albertChien-tw]

while sync favorites files is failure sometimes beacase not in the main thread

---

BUGS & IMPROVEMENTS

• (1) Multiple deletion fix the warning in main thread #1061 (comment)
• (2) Multiselection mode with no items selected fix the warning in main thread #1061 (comment)
• (3) Selections are not cleared fix the warning in main thread #1061 (comment)

[CLAassistant]

All committers have signed the CLA.

[jesmrec]

Thanks for the contribution! to be included in next 3.8.0 version.

In any case, we are working in a new project: https://github.com/owncloud/ios-app in which you can contribute as well!!

[jesmrec]

i will start a QA stage to the multiselection feature.

[jesmrec]

BUG (1)

Steps

1. Tap on edit
2. Select some files
3. Tap on Done
4. Select "Delete" (no matter if local or remote)

Current behaviour: Only is deleted the first one (locally)
Expected: All selected files are deleted locally

Tested with: iOS11.4

[jesmrec]

BUG (2)

Steps

1. Tap on Edit
2. Tap on Done with no selection

Current: Sheet with options displayed
Expected: no item was selected, so the options should not be displayed

Tested with: iOS11.4

[jesmrec]

BUG (3)

Steps

1. Tap on Edit
2. Select items
3. Tap on Done
4. Tap on Cancel (edit mode is closed)
5. Tap again on Edit

Current: Previous selection remains
Expected: Previous selections should be cleared after "Done"

Tested with: iOS11.4

[jesmrec]

Why is the file list moved to the right when you tap on "Edit"? i guess it is for showing the multiselection mode. The point is that blank at the left should be placed with any indicator or similar.

[jesmrec]

@dabechien will you check the bugs & improvements? in order to continue the process to improve the PR quality.

[albertChien-tw]

Dear All I am going to military service recently. Will not be updated in the near future Wait for the military service to come back and update it again. I hope to be a contributor to owncloud Thanks Dabechien 2018-08-02 16:19 GMT+08:00 Jesús Recio Rincón <[email protected]>:

…

@dabechien <https://github.com/dabechien> will you check the bugs & improvements? in order to continue the process to improve the PR quality. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1061 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK8ESvuAzNS8hZrVeSwM9P2JV4gqL3fbks5uMrYMgaJpZM4UcS8j> .

[jesmrec]

ok, thanks for your engagement. When you come back, ping us, to move forward the stuff.

do not forget that we are working in a new iOS project:

https://github.com/owncloud/ios-app
https://github.com/owncloud/ios-sdk

it would be cool you to take part there!!