[RELEASE] 12.1

[jesmrec]

Release a new version

Xcode version to work with: 15.1

TASKS:

Git & Code

• [GIT] Create branch release/[major].[minor].[patch] (freeze the code)
• [DEV] Update APP_SHORT_VERSION [major].[minor].[patch] in ownCloud.xcodeproj/project.pbxproj
• [TRFX] Update translations from transifex branch.
• [TRFX] Check for missing translations.
• [DIS] Update changelog
• [DEV] Update In-App Release Notes (changelog) in ownCloud/Release Notes/ReleaseNotes.plist
• [DEV] Changelog: Created a folder for the new version like $majorVersion.$minorVersion.$patchVersion_YYYY-MM-DD
• [DEV] Changelog: Moved all changelog files from the unreleased folder to the new version folder
• [DEV] Inform Documentation-Team for the upcoming major/minor release with new version tag (notify #documentation-internal)
• [QA] Design Test plan
• [QA] Regression Test plan
• [DOC] Update https://owncloud.com/mobile-apps/#ios version numbers (notify #marketing)
• [GIT] Merge branch release/[major].[minor].[patch] in master
• [GIT] Create tag and sign it [major].[minor].[patch]
• [GIT] Add the new release on GitHub ios-app
• [DEV] ownBrander: Update the ownBrander git tag in repository customer_portal to new release tag
• [DEV] Update used Xcode version for the release in .xcode-version
• [DEV] Inform #documentation about the new release to set new documentation branch tag

If it is required to update the iOS-SDK version:

• [GIT] Create branch library release/[major].[minor].[patch](freeze the code)
• [mail] inform #marketing about the new release.
• [DIS] Update README.md (version number, third party, supported versions of iOS, Xcode)
• [DIS] Update changelog
• [GIT] Merge branch release/[major].[minor].[patch] in master
• [GIT] Create tag and sign it [major].[minor].[patch]
• [GIT] Add the new release on GitHub ios-sdk

If it is required to update third party:

• [DIS] Update THIRD_PARTY.txt

App Store

• [DIS] App Store Connect: Create a new version following the [major].[minor].[patch]
• [DIS] App Store Connect: Trigger Fastlane screenshots generation and upload
• [DIS] Upload the binary to the App Store
• [DIS] App Store Connect: Trigger release (manually)
• [DIS] App Store Connect: Decide reset of iOS summary rating (Default: keep)
• [DIS] App Store Connect: Update description if necessary (coordinated with #marketing)
• [DIS] App Store Connect: Update changelogs
• [DIS] App Store Connect: Submit for review

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Backend/oCIS/iOS%20vs%205.0.0.md

(executed to validate also oCIS 5)

BUGS & IMPROVEMENTS:

• (1) Setting Preserve name of files not working [RELEASE] 12.1 #1300 (comment)
• (2) Share by cloud in oCIS [RELEASE] 12.1 #1300 (comment)

[jesmrec]

Issues to check in QA phase

• [BUG] Toggling cellular data settings causes app to crash #1299 (if finally fixed)
• [FEATURE REQUEST] Preserve file extension when creating new files (Document Scanner, App Provider etc) #1292
• [BUG] Share link can’t be named / renamed anymore #1246
• [fix/fp-no-account] Show message in File Provider if no account has been set up #1306
• [feature/remove-intents-extension] Remove Extension Build Flag (Intents) #1307
• [fix/fp-fixes] File Provider fixes #1294

Special attention:

• Open Links in app #1295

[michaelstingl]

@jesmrec @hosy please double check EMM + oC.online app icons and other visual stuff.

[jesmrec]

(1)

Severity: medium

1. In Settings enable Media Upload > Preserve original media file names
2. In the list of files, click on + Take photo or video
3. Take a picture

Current: Picture uploaded with name Photo-<timestamp>

Expected: Picture uploaded with name IMG_xxxx

iPhoneXR 17.2
e417f2ea + 74156a0

[jesmrec]

(2)

Severity: medium-high

1. Add an oCIS account to the app
2. Open Files app
3. Select any item in the account and Share by cloud

Current: Connecting...
https://github.com/owncloud/ios-app/assets/14894746/7082a874-8a62-461d-b72a-22ab4b6dcb66

Expected: Open share view

I caught some logs:
ownCloud_20_Dec_2023_at_10_38_27.log.txt

Only reproducible in oCIS, oC10 works fine

iPhoneXR 17.2
e417f2ea + 74156a0

[jesmrec]

Not a blocker, but sometimes i got some weird behaviours executing copy/move operations in Files app. I could not get specific steps or logs but i will put an eye and probably will do a sanity test over Files app early 2024

[felix-schwarz]

@jesmrec (1) works as designed. When taking a photo, iOS doesn't return an image file but just the image data in memory, which the app then compresses to a file, using the Photo-$timestamp.$suffix pattern.

(2) likely is caused by an account where login fails (there's an error message flashing briefly in your video), but of course the UX shouldn't be like that when that happens. I'm looking into it.

[felix-schwarz]

@jesmrec Re (2): Upon closer inspection of the log you provided, I found that the File Provider UI can't connect to the server instance not because of invalid authentication data but due to certificate issues:

2023-12-20 10:38:46.557000+0100 ownCloud File Provider UI[793:137437] [dbug] | [HTTP, Response, …] RESPONSE 41E58DC7-E7D5-4AA7-BCDC-A2ACAEF77A8C 

{
  "response": {
    "body": {},
    "info": {
      "id": "41E58DC7-E7D5-4AA7-BCDC-A2ACAEF77A8C",
      "method": "GET",
      "reply": {
        "status": 0,
        "metrics": "{ total: [2023-12-20 09:38:46 +0000 - 2023-12-20 09:38:46 +0000, 0.17 sec], startedAfter: 0.00, redirects: 0, transactions: [1: fetchStart: 0.00] }",
        "error": "Error Domain=NSURLErrorDomain Code=-1200 \"An SSL error has occurred and a secure connection to the server cannot be made.\" UserInfo={NSLocalizedRecoverySuggestion=Would you like to connect to the server anyway?, _kCFStreamErrorDomainKey=3, NSErrorPeerCertificateChainKey=(\n    \"<cert(0x13c019c00) s: OCIS i: OCIS>\"\n), NSErrorClientCertificateStateKey=0, NSErrorFailingURLKey=https://65.108.212.199:9200/status.php, NSErrorFailingURLStringKey=https://65.108.212.199:9200/status.php, NSUnderlyingError=0x280c8bea0 {Error Domain=kCFErrorDomainCFNetwork Code=-1200 \"(null)\" UserInfo={_kCFStreamPropertySSLClientCertificateState=0, kCFStreamPropertySSLPeerTrust=<SecTrustRef: 0x2833d8dc0>, _kCFNetworkCFStreamSSLErrorOriginalValue=-9802, _kCFStreamErrorDomainKey=3, _kCFStreamErrorCodeKey=-9802, kCFStreamPropertySSLPeerCertificates=(\n    \"<cert(0x13c019c00) s: OCIS i: OCIS>\"\n)}}, _NSURLErrorRelatedURLSessionTaskErrorKey=(\n    \"LocalDataTask <4ABF6884-29A4-42D4-AFCC-B17E80B33D0D>.<3>\"\n), _kCFStreamErrorCodeKey=-9802, _NSURLErrorFailingURLSessionTaskErrorKey=LocalDataTask <4ABF6884-29A4-42D4-AFCC-B17E80B33D0D>.<3>, NSURLErrorFailingURLPeerTrustErrorKey=<SecTrustRef: 0x2833d8dc0>, NSLocalizedDescription=An SSL error has occurred and a secure connection to the server cannot be made.}"
      },
      "url-session-task-id": 3,
      "url": "https://65.108.212.199:9200/status.php"
    },
    "header": {}
  }
}

That is reported as an issue by the OCCore, but in the FileProviderUI, there's currently no handler for issues, so that the core picks the safe defaults (reject certificate) and stubbornly tries again - which gives you the loop you see.

Due to the complexity issue handling can have, it's probably not possible to handle those issues right in the FileProviderUI, but I'll check if I can at least display the issue message and refer the user to the app in that case.

[jesmrec]

@jesmrec (1) works as designed. When taking a photo, iOS doesn't return an image file but just the image data in memory, which the app then compresses to a file, using the Photo-$timestamp.$suffix pattern.

this behaviour i noticed is different in two cases:

• Upload manually a picture/video
• Take from camera a picture/video

First case, file name is different depending on the setting (OK). Second case, file name is the same regardless the setting value.

Is that expected? in both cases, app is taken from iOS system afaik.

[felix-schwarz]

@jesmrec Yes, that works as expected:

• when uploading a picture from the iOS photo roll / Photos, the system provides an actual file with a file name, which can then be used - or changed, depending on the setting
• when taking a photo right in the app, iOS provides a system UI similar to the Photo app, but then does not return a file or a filename to the app - only image data in memory. In that case, the app always (needs to) generate a filename on its own, because the system does not provide any.

[jesmrec]

Done