Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encryption issues after the impersonator logs out #189

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Nov 25, 2021

We now save the private key in another session variable to preserve and reset it after an impersonator logs out to use their original user again.

I also refactored some unit tests and added a namespace in the info.xml file.

Steps to reproduce:

  • Enable encryption
  • Impersonate another user
  • Logout to switch back to your user again -> there shouldn't be any issues with encryption whatsoever.

fixes https://github.com/owncloud/enterprise/issues/4887

@JammingBen JammingBen added the bug label Nov 25, 2021
@JammingBen JammingBen self-assigned this Nov 25, 2021
@JammingBen JammingBen changed the title Fix encryption issues after the impersonater logs out Fix encryption issues after the impersonator logs out Nov 25, 2021
lib/Util.php Show resolved Hide resolved
lib/Util.php Show resolved Hide resolved
lib/Util.php Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit cd28bf0 into master Nov 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-encryption branch November 26, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants