More param validation #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@LukasReschke - This needs to be reviewed soon if it's to make the 8.2.3 release |
|
Good stuff. I'd however recommend not to backport it since there can't be done too many shenanigans with it and that's a rather huge change 😄 👍 |
|
Thanks for the review! :) |
* Better document some test cases * Add tests to detect bad config values
oparoz
force-pushed
the
more-param-validation
branch
from
3f27f69 to
5fdf7fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a good idea to validate user fed parameters before sending them to the browser...
Fixes #445
@LukasReschke