Close the share dialogue when performing another action

[oparoz]

Bug report

Steps to reproduce

1. Open the share dialogue
2. Click on an album

or

1. Open the share dialogue
2. Click on the info button

Expected behaviour

The share dialogue should close

Actual behaviour

The share dialogue stay open

[virajparimi]

I would like to work on this one. Could you guide me as to in which file changes are to be made.

[oparoz]

Well, the first step is to determine what is wrong.

Basically, when _openAlbum is called, all the dialogues, including the share dialogue should be closed and it's not the case.

So should this method be modified or is there another way?

[virajparimi]

Should we use hideDropDown function when _openAlbum is called.

[oparoz]

I think that's the method to call, yes.
There is another problem though, the share dialogue also stays open when clicking on the info button (enabled when there is a description. See https://github.com/owncloud/gallery/wiki/Gallery-configuration#album-presentation).

So maybe we should use this instead:
https://github.com/owncloud/gallery/blob/master/js/app.js#L41-L43

[virajparimi]

I have figured out the solution and it is working fine. Shall i send a pull request.

[oparoz]

Please do. That way we I and other can test the solution :).
Note: Always create the PR against master.

[oparoz]

@viraj96 - There is a regression.

That's not available in the Files app:
https://github.com/owncloud/gallery/blob/master/js/slideshow.js#L95-L96

So the call should be made in the method which calls show()

[virajparimi]

So, can I add it here -->.

[oparoz]

Yes, right at the end should work.