Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Gallery compatible with shorter URLs from 9.0 #515

Closed
2 tasks done
oparoz opened this issue Feb 11, 2016 · 4 comments
Closed
2 tasks done

Make Gallery compatible with shorter URLs from 9.0 #515

oparoz opened this issue Feb 11, 2016 · 4 comments
Assignees
Milestone

Comments

@oparoz
Copy link
Contributor

oparoz commented Feb 11, 2016

It seems shorter URLs have been introduced in 9.0, but Gallery doesn't support them.

  • Fix page detecting JS in app.php
  • Fix Gallery button
@oparoz
Copy link
Contributor Author

oparoz commented Feb 11, 2016

@LukasReschke - Is this a standard feature in 9.0 or is this optional?

@LukasReschke
Copy link
Member

@LukasReschke - Is this a standard feature in 9.0 or is this optional?

Enabled if the web server supports it, it should also not really require any work on your side if you have mod_env and mod_rewrite enabled. It should use short URLs then if you use the default IURLGenerator plus the ownCloud core JS functions.

@oparoz
Copy link
Contributor Author

oparoz commented Feb 11, 2016

Thanks! Unfortunately, work is required because we check the URL to only load our JS on the files and files_sharing apps and the regexp contains index.php. I'll remove that and hope URLs don't contain /s/ until files_sharing supports loadAdditionalScripts

@LukasReschke
Copy link
Member

Your welcome. Thanks for fixing @oparoz 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants