Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listen for loadAdditionalScripts to load our Javascript in Files and Sharing #501

Closed
oparoz opened this issue Jan 23, 2016 · 5 comments
Closed

Listen for loadAdditionalScripts to load our Javascript in Files and Sharing #501

oparoz opened this issue Jan 23, 2016 · 5 comments
Labels
blocked by core enhancement
Milestone
backlog

Comments

@oparoz
Copy link
Contributor

oparoz commented Jan 23, 2016

Since we have to touch that part of the code anyway, thanks to the shorter URLs coming in 9.0, we should use loadAdditionalScripts to load our Javascript in Files and Sharing instead of detecting the pages we're on.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@oparoz oparoz added this to the 9.0-current milestone Jan 23, 2016
@oparoz
Copy link
Contributor Author

oparoz commented Jan 23, 2016

The dispatcher is missing from files_sharing, which means we currently can't load the slideshow on shared folders.

@oparoz
Copy link
Contributor Author

oparoz commented Jan 23, 2016

Because we have to listen for 2 events, we'll have to move the function out of app.php. Probably to utility...

@oparoz oparoz changed the title Listen for loadAdditionalScripts to load our Javascript in Files Listen for loadAdditionalScripts to load our Javascript in Files and Sharing Jan 23, 2016
@oparoz oparoz added the bug label Feb 9, 2016
@oparoz
Copy link
Contributor Author

oparoz commented Feb 11, 2016

Split the ticket in 2.
#515 is to make short URLs work on 9.0 and this ticket will be about implementing loadAdditionalScripts

@oparoz oparoz modified the milestones: 9.1-next, 9.0-current Feb 11, 2016
@oparoz
Copy link
Contributor Author

oparoz commented Mar 24, 2016

This will be implemented once owncloud/core#22328 is done

@oparoz oparoz modified the milestones: 9.2-next, 9.1-current, backlog Jun 16, 2016
@oparoz oparoz mentioned this issue Sep 4, 2016
Open
@oparoz
Copy link
Contributor Author

oparoz commented Sep 4, 2016

This issue was moved to nextcloud/gallery#111

@oparoz oparoz closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked by core enhancement
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
1 participant
@oparoz