No possibility to send an email in share dialog

[sonymaster]

If you open the share dialog from the top right share button, you can share the gallery with OC users or/and as Link. But the possibility to send an email with share infos is not displayed like in the Files app.

[oparoz]

You're correct, thanks for notifying us.

[oparoz]

@rullzer @PVince81 - Is there something special to do to get the share by email section in the share dropdown?

[imjalpreet]

@oparoz Can you please give little more detail regarding this? I am not exactly able to figure out what the problem is. I didn't understand the line : "..possibility to send an email with share infos..". Thanks!

[oparoz]

If you compare the dialogue in Gallery with the one in Files, you'll notice that you cannot send an email in Gallery after having created a share or a public link.
There are screenshots in #498.

Also, in share.js I've commented out the code as it's not in use. You need to uncomment the parts relevant to email sharing and update it to make it work like the rest of the class.

[oparoz]

This commit should help you see the changes made to the ajax calls: 48cf853#diff-b3a827de53066e0a69e83addf18ddd46

[imjalpreet]

@oparoz Thanks! I will come up with a solution as soon as possible. I am trying to understand the flow right now.

[oparoz]

That class is a pita... This one is easier to understand because it doesn't have all the UI stuff mixed up:
https://github.com/owncloud/core/blob/master/core/js/shareitemmodel.js

Eventually, we should migrate to that, using Backbone.

[imjalpreet]

@oparoz I wanted to ask you a question. When I am trying to send a mail from files app, I am getting an error message(attached screenshot). Can you tell me do we have to setup mail before this? Thanks!

[oparoz]

I don't see the screenshot, but look in the admin settings. There you can authorise emails to be sent.

[imjalpreet]

@oparoz No problems. I have figured out how to do it. Thanks!

[oparoz]

Ah, good :)

[oparoz]

And if admin settings are involved, don't forget to add that to your test plan. It would have to be tested with and without them in order to see if the interface adapts to the settings.

[oparoz]

@sonymaster - Fix is in #586

[imjalpreet]

Fix in #586