Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn the Gallery button into a switch #145

Closed
oparoz opened this issue May 18, 2015 · 3 comments
Closed

Turn the Gallery button into a switch #145

oparoz opened this issue May 18, 2015 · 3 comments
Assignees
@oparoz
Labels
enhancement Gallery+

Comments

@oparoz
Copy link
Contributor

oparoz commented May 18, 2015

It would be more immediately understandable if there was a switch with both the Gallery and Files button, as shown here:
0ebbfcfc-fcdb-11e4-877c-873b19def287
@oparoz oparoz mentioned this issue May 19, 2015
Closed
oparoz added a commit that referenced this issue May 20, 2015
@oparoz
Turn the Gallery button into a switch
7628b2a 
Implementation of #145
@oparoz oparoz mentioned this issue May 20, 2015
Merged
@oparoz oparoz added this to the 8.0.12 milestone May 20, 2015
oparoz added a commit that referenced this issue Jun 22, 2015
@oparoz
Turn the Gallery button into a switch
3ab01b6 
Implementation of #145
This was referenced Jun 22, 2015
Merged
Merged
oparoz added a commit that referenced this issue Jun 25, 2015
@oparoz
Turn the Gallery button into a switch
369db1f 
Implementation of #145
oparoz added a commit that referenced this issue Jun 25, 2015
@oparoz
Turn the Gallery button into a switch
85b995e 
Implementation of #145
oparoz added a commit that referenced this issue Jun 25, 2015
@oparoz
Turn the Gallery button into a switch
68bfc58 
Implementation of #145
oparoz added a commit that referenced this issue Jun 29, 2015
@oparoz
Turn the Gallery button into a switch
0b54bf7 
Implementation of #145
@oparoz oparoz modified the milestones: 13, 12 Jun 29, 2015
@oparoz oparoz modified the milestones: 14 (215-07-19), 13 (2015-07-12) Jul 10, 2015
oparoz added a commit that referenced this issue Jul 11, 2015
@oparoz
Turn the Gallery button into a switch
c9cac59 
Implementation of #145
oparoz added a commit that referenced this issue Jul 11, 2015
@oparoz
Turn the Gallery button into a switch
76e1bfa 
Implementation of #145
jancborchardt added a commit that referenced this issue Jul 25, 2015
@jancborchardt
Merge pull request #145 from owncloud/progress-bar-height
84209ae 
fix progressbar height
oparoz added a commit that referenced this issue Jul 25, 2015
@oparoz
Turn the Gallery button into a switch
0481e1e 
Implementation of #145
@oparoz oparoz added the v8.2 label Jul 25, 2015
oparoz added a commit that referenced this issue Jul 29, 2015
@oparoz
Turn the Gallery button into a switch
041410a 
Implementation of #145
@oparoz oparoz removed the v8.0 label Jul 30, 2015
@oparoz oparoz removed the v8.1 label Jul 30, 2015
oparoz added a commit that referenced this issue Aug 31, 2015
@oparoz
Turn the Gallery button into a switch
894d3ad 
Implementation of #145
@oparoz
Copy link
Contributor Author

oparoz commented Sep 8, 2015

Change has been rejected. Will keep in Gallery+ for 8.1 and 8.0

@oparoz oparoz closed this as completed Sep 8, 2015
@oparoz oparoz added the Gallery+ label Sep 8, 2015
@oparoz oparoz removed this from the 8.2-current milestone Sep 8, 2015
@oparoz oparoz reopened this Sep 8, 2015
@oparoz oparoz self-assigned this Sep 8, 2015
@jancborchardt
Copy link
Member

@oparoz sorry again for swaying back and forth on this one. Oftentimes design has to be carefully evaluated as you know. :) Especially when it’s that present in our main Files app.

@oparoz
Copy link
Contributor Author

oparoz commented Sep 8, 2015

Yep, no hard feelings :)
Since 8.0 and 8.1 have the old design, it will work there and I'll be able to get some feedback :)

oparoz added a commit that referenced this issue Sep 11, 2015
@oparoz
Turn the Gallery button into a switch
0d55350 
Implementation of #145
oparoz added a commit that referenced this issue Sep 15, 2015
@oparoz
Turn the Gallery button into a switch
377ba7c 
Implementation of #145
@oparoz oparoz closed this as completed Sep 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oparoz oparoz

Labels
enhancement Gallery+
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oparoz @jancborchardt