Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests for public webDAV API step #335

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Oct 24, 2019

Fix for failing tests in drone due to core code change.
https://drone.owncloud.com/owncloud/files_antivirus/972/21/12

Also add new scenarios for new public webDAV API

@dpakach dpakach self-assigned this Oct 24, 2019
@dpakach dpakach requested review from phil-davis and individual-it and removed request for phil-davis October 24, 2019 11:20
@dpakach dpakach changed the title Fix failing tests for new public webDAV API step Fix failing tests for public webDAV API step Oct 24, 2019
@phil-davis
Copy link
Contributor

phil-davis commented Oct 25, 2019

Now there is just an Oracle fail: https://drone.owncloud.com/owncloud/files_antivirus/975/25/8

+ cd /var/www/owncloud/server
+ php occ a:l
An unhandled exception has been thrown:
Error: Cannot declare self-referencing constant 'Doctrine\DBAL\Driver\OCI8\OCI_COMMIT_ON_SUCCESS' in /var/www/owncloud/server/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Driver/OCI8/Driver.php:39

???

Update: all CI with Oracle is broken by an owncloudci/php docker image update. So we need to wait for that to be fixed.

@phil-davis
Copy link
Contributor

The Oracle CI problem has been fixed. I restarted drone CI - let's see.

@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #335   +/-   ##
=========================================
  Coverage     58.36%   58.36%           
  Complexity      277      277           
=========================================
  Files            35       35           
  Lines          1244     1244           
=========================================
  Hits            726      726           
  Misses          518      518

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0727b...2e51223. Read the comment docs.

@phil-davis phil-davis merged commit 6c5c428 into master Oct 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-failing-tests branch October 25, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants