files_antivirus 1.0.0

[jnweiger]

Reason

• Release needed for ICAP support; Allow to use a scanner class living outside the files_antivirus app #379 Allow to use a scanner class living outside the app
• Move executable options into config.php Move executable options into config.php #442

Product approval

• Verify transifex commits are in master: If a folder https://github.com/owncloud/file_antivirus/tree/master/l10n exists, then https://drone.owncloud.com/owncloud/files_antivirus should receive nightly '[tx] updated from transifex` ...
• Ping pmaier to check info.xml description and screenshot
• Get approval on translations from pmaier - send the date of the last tx commit from drone to Patrick
• info.xml update Update info.xml for initial release #415

QA

• Generate Changelog
• Create QA Milestone and set the description to $version
• Move items from development to qa
• Create release branch with the format "release-$version"
• Create "$version Testplan" [QA] 1.0.0 Testplan #391

Documentation

• Changes in the docs needed? If so create issue in owncloud/docs.

Marketing

• Ping @owncloud/marketing

Build

All actions to be done on the release branch from here:

• Bump version in info.xml (no version suffix)
• Check php version dependency in info.xml
• Check minimum ownCloud version dependency in info.xml
• Change CHANGELOG.md 'Unreleased' to '$version' (today's date)

Beta/RC

• Create github tag for v${version}RC1 on release branch
• Build and sign RC tarball from github tag v${version}RC1 (see
  handbook for how to build)
• Upload as Github release using changelog entries
• Test and document in testplan => Final "Go" from QA (set 'QA-ready' label) => else do another RC after fixing issues in the "release-$version" branch

Final

• Check that no documentation issues are pending
• Rename last RC tarball to final
• Create github tag for final v${version} on release branch
• Upload as Github release using changelog entries

Publishing

• Upload tarball to marketplace (see handbook in confluence for details)
• Publish tarball for customers (see handbook in confluence for details) - https://customer.owncloud.com and https://portal.owncloud.com
• Send mail to release-coordination with link to this ticket and to the changelog
• Copy email to rocket chat #updates channel

Post-release

• Rename QA milestone to $version
• Add a new 'Unreleased' section in CHANGELOG.md (and also update links at the bottom!)
• Create PR to merge changes back to the master branch with
  description "Closes #XYZ" with the release ticket number
• Close the milestone
• Ensure release template is up to date

[jnweiger]

Issues opened while testing 0.16.0

• [QA] signing files_antrivirus 0.16.0 fails #393 - [QA] signing files_antrivirus 0.16.0 fails
• [QA] occ app:check fails #394 - [QA] occ app:check fails
• [QA] eicar virus produces wrong error message #395 - [QA] eicar virus produces wrong error message [QA] eicar virus produces wrong error message #395
• [QA] default mode 'executable' is slowest #396 - [QA] default mode 'executable' is slowest
• [QA] Documentation: log/delete choice #397 - [QA] Documentation: log/delete choice
• [QA] admin UI disappears when 'files-antivirus.scanner-class' is set #400 - [QA] admin UI disappears when 'files-antivirus.scanner-class' is set
• [QA] download from external storage is not scanned #401 - [QA] download from external storage is not scanned

[jnweiger]

tested with 0.16.0RC1: installed sucessfully at oc10.6.0

Setup done for

• internal clamav
• Clamav c-icap (docker deepdiver/icap-clamav-service)
• Kaspersky Scan engine 2.0.0.1157 (./install with GUI)
  via hetzner-deploy/setup_icap_kaspersky.sh

[jnweiger]

Testplan #391 completed with issues.
See the lists in #385 (comment) and https://github.com/owncloud/icap/issues/5#issuecomment-777289481
I recommed that at least #395, #400 and https://github.com/owncloud/icap/issues/22, https://github.com/owncloud/icap/issues/23 should be addressed for the release.

[DeepDiver1975]

we just merged #413 into master
this adds McAfee support - we might want to add this to docs, release notes as well as app description

@hodyroff @pmaier1 @micbar

[jnweiger]

Back to dev. 0.16.0 will not happen like this. A 1.0.0 beta is under way.

[pmaier1]

Info.xml update #415

[micbar]

Found a release bocker

• Can upload virus file with new public WebDAV API
  Fix Check content before create for public upload case #434 is ready for review.

[C0rby]

https://gitea.owncloud.services/security/files_antivirus/pulls/1 also needs to be included to the release.

[jnweiger]

@pmaier1 Do we want to pull https://github.com/owncloud/icap/pull/30/commits/a2995f22937d7c98015dfb4a2dde36cf00bb8a6a into release-1.0.0 ?

[VicDeo]

@jnweiger if i'm not mistaken https://github.com/owncloud/icap/commit/a2995f22937d7c98015dfb4a2dde36cf00bb8a6a was merged as #415

#442 is critical for release as it is port of https://gitea.owncloud.services/security/files_antivirus/pulls/1 to the app code base

also Beta 3 has the following fixes for ICAP feature in addition to listed in the release:
#438 (fixed with #441)
#433 (fixed with #440)

[jnweiger]

Changlog Testing with 1.0.0-rc2

• Prevent upload virus file with new public WebDAV API - #334
• Prefer daemon or socket to executable mode if any of those is available #399
• fix: handle McAfee response #413
• Update info.xml for initial release Update info.xml for initial release #415
• docs: fix icap setup - #417
• [QA] The system becomes unresponsive when ClamAV service has stopped [QA] The system becomes unresponsive when ClamAV service has stopped #419
• Improve validation pattern to check whether port number is in [1, 65535] range Improve validation pattern to check whether port number is in [1, 65535] range #423
• Prevent from crashing on missing or expired license #426
• Hide ICAP-specific options if mode is not ICAP Hide ICAP-specific options if mode is not ICAP #440
• Do not scan an empty content in ICAP mode Do not scan an empty content in ICAP mode #441
• Move executable options into config.php Move executable options into config.php #442 (aka https://gitea.owncloud.services/security/files_antivirus/pulls/1 )

[jnweiger]

Issues opened while testing 1.0.0

• [QA] Field validation passing Port number > 65535 on Antivirus Configuration screen #422 - [QA] Field validation passing Port number > 65535 on Antivirus Configuration screen
  Fixed with Improve validation pattern to check whether port number is in [1, 65535] range #423

20210520

• [QA] add files_antivirus.av_* variables to docs - [QA] add files_antivirus.av_* variables to admin_manual/configuration/server/config_sample_php_parameters.html docs#3586
• [QA] McAfee takes 20sec per file - https://github.com/owncloud/enterprise/issues/4580
• [QA] cannot upload files larger than ca. 20 MB - [QA] cannot upload files larger than ca. 20 MB #443
• Can upload virus file with new public WebDAV API - Can upload virus file with new public WebDAV API #334 (reopened)

[mmattel]

• As we have now updated docs reflecting the changes, you should rethink if you want to describe settings in the UI or pointing to docs. Atm, the text looks akward as is is multiline and has a non professional look.
• The Mcafee setting was taking all values to work, not only the particular highlighted one.

For both, there was a chat discussion with @jnweiger during writing the docs.

[pmaier1]

I guess you are referring to this one. I agree that we should remove the specific configuration hints and point to the docs. Anyway, this is cosmetic, not a blocker for the release. Let's fix it afterwards.

• Remove "possible values..."
• Add link to docs