Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for ocis 4.0.2 #4891

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Add release notes for ocis 4.0.2 #4891

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e92443e
Add release notes for ocis 4.0.2
mmattel Oct 9, 2023
bfdddac
Merge branch 'master' into ocis_4.0.2_release_notes
mmattel Oct 9, 2023
0b8f20d
Minor grammar adjustment to 4.0.2 release notes
phil-davis Oct 9, 2023
7c24163
Merge branch 'master' into ocis_4.0.2_release_notes
mmattel Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions modules/ROOT/pages/ocis_release_notes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,30 @@

toc::[]

== Infinite Scale 4.0.2

[discrete]
=== General

This is a patch release only, please update as soon as possible.

[discrete]
=== Issues Fixed

* Fixed a problem where the states of received shares were reset to PENDING in the `ocis migrate rebuild-jsoncs3-indexes` command. https://github.com/owncloud/ocis/pull/7336[#7336]

* Fixed an issue that allowed to create two schools with the same school number. https://github.com/owncloud/ocis/pull/7351[#7351]
phil-davis marked this conversation as resolved.
Show resolved Hide resolved

* Actually pass `PROXY_OIDC_SKIP_USER_INFO` option to oidc client middleware. https://github.com/owncloud/ocis/pull/7220[#7220]

* Reintroducing the `USERS_LDAP_USER_SCHEMA_ID` variable which was accidently removed from the users service
with the 4.0.0 release. https://github.com/owncloud/ocis/pull/7321[#7321]

* Always pass adjusted default nats options. https://github.com/cs3org/reva/pull/4214[cs3org/reva#4214]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a complete list. Not needed IMO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We always mention one important one and link to the full changelog.

Copy link
Contributor Author

@mmattel mmattel Oct 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree on the "not needed" statement.

  • We provide this info for server patch releases (see 10.13.1 and the upcoming 10.13.2)
  • We provide this info for ocis patch releases (see 4.0.1)
  • All external code we use eg for building docs provide a changelog for patch releases.
    And as far I can tell, this is true for ocis, core and all other repos.

Therfore we stick to this well known and accepted behaviour and I see no reason we should break this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you got me wrong. I was referring to the list of full changes. We always link to the list of full changes.

For me it is weird if we see a list of full changes on path releases but not on minor or major ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this sounds a bit different now, I get the point.

On a list of 62 changes as we had in 4.0.0, we picked the 12 most important ones and referenced the rest to the full blown changelog.
On 10.13.1 we described 4 out of 9.
On 10.13.2 we will describe 7out of 7

For 4.0.2 we describe 6 changes out of 6 which sounds totally fine and inline from the quantity pov. If you would like to have that different, I need to know which ones you would like to drop and where to reference for the full list.

For server we have a good changelog including patch releases at: https://owncloud.com/changelog/server/ but for ocis, we are lacking the patch releases part in: https://owncloud.com/changelog/infinite-scale/ --> which is not imho professional and should be fixed. But we have a changelog in https://github.com/owncloud/ocis/releases/tag/v4.0.2 ...

I have not searched for it, but I found it and as you can believe, was not happy about 😵 🤪

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for ocis, we are lacking the patch releases part in: https://owncloud.com/changelog/infinite-scale/

I see your point. Let me explain. ocis 4.0.2 is already the "old" version. The current is the 5.0.0-prealpha The changelog is available as a permalink https://raw.githubusercontent.com/owncloud/ocis/stable-4.0/CHANGELOG.md

For oc10 this is by the way the same. In oc10 we do not show previous 9.x.x patch release. The website refers for both products to the changelog on the "master" branch.

We should improve that @rpausch-owncloud @mmattel

I am open for suggestions. The changelog is available for all ocis branches. Maybe we need a dropdown?


* In the yaml example for Keycloak, set `GRAPH_USERNAME_MATCH` to `none`, to accept any username that is
also valid for keycloak. https://github.com/owncloud/ocis/pull/7230[#7230]

== Infinite Scale 4.0.1

[discrete]
Expand Down
4 changes: 2 additions & 2 deletions site.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@ asciidoc:
latest-ocis-version: 'next'
previous-ocis-version: 'next'
# these versions are just for printing like in releases but not used for referencing
ocis-actual-version: '4.0.1'
ocis-actual-version: '4.0.2'
ocis-former-version: '3.0.0'
ocis-compiled: '2023-09-01 00:00:00 +0000 UTC'
ocis-compiled: '2023-10-06 00:00:00 +0000 UTC'
ocis-downloadpage-url: 'https://download.owncloud.com/ocis/ocis/stable/'
# webui
latest-webui-version: 'next'
Expand Down