Clarify log/delete choice actions in files_antivirus #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmattel
reviewed
Feb 20, 2021
modules/admin_manual/pages/configuration/server/virus-scanner-support.adoc
Outdated
Show resolved
Hide resolved
phil-davis
force-pushed
the
jnweiger-clarify-log-delete
branch
from
9097f22 to
01021ca
Compare
phil-davis
reviewed
Feb 24, 2021
|
|
||
| * The upload is blocked. | ||
| * The event is logged in the owncloud server log | ||
| * The event is reported and/or logged by the client / Web UI. |
There was a problem hiding this comment.
I made this a separate point because, for example, the web UI reports the "infected file" response but it does not "log" it anywhere to a "permanent" file. Depending on the client, it might or might not either report, or log, or both.
mmattel
approved these changes
Feb 24, 2021
|
backport to 10.5 and 10.6 necessary |
I will make backports now... |
This was referenced Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes owncloud/files_antivirus#397