Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add known issue with password policy to release notes #2446

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Add known issue with password policy to release notes #2446

merged 3 commits into from
Mar 16, 2020

Conversation

pmaier1
Copy link
Contributor

@pmaier1 pmaier1 commented Mar 16, 2020

No description provided.

@pmaier1 pmaier1 requested review from settermjd and phil-davis March 16, 2020 08:28
@pmaier1 pmaier1 self-assigned this Mar 16, 2020
phil-davis
phil-davis previously approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Will readers realize that if you do not have the password policy app installed, then this is not an issue at all?

@settermjd
Copy link
Contributor

LGTM.
Will readers realize that if you do not have the password policy app installed, then this is not an issue at all?

Good point, which is worth drawing attention to, in case users who both aren't aware and don't have the app installed spend time investigating only to find out that they didn't need to be concerned about it.

settermjd
settermjd approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@settermjd settermjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmaier1, I made a small change to the PR, based on feedback from @phil-davis. Please let me know if you're okay with it.

@pmaier1
Copy link
Contributor Author

pmaier1 commented Mar 16, 2020

Thanks!

@pmaier1 pmaier1 merged commit 2036a13 into master Mar 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the pmaier1-patch-1 branch March 16, 2020 11:18
@pmaier1
Copy link
Contributor Author

pmaier1 commented Mar 16, 2020

Please backport @settermjd

This was referenced Mar 25, 2020
Closed
Merged
Merged
@phil-davis
Copy link
Contributor

Backports to
10.4 #2489
10.3 #2490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@settermjd settermjd settermjd approved these changes

Assignees

@pmaier1 pmaier1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmaier1 @settermjd @phil-davis