Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helmchart notification secrets #645

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Helmchart notification secrets #645

merged 4 commits into from
Oct 17, 2023

Conversation

case0sh
Copy link
Contributor

@case0sh case0sh commented Oct 16, 2023

  • userlog global notifications secret

@case0sh case0sh force-pushed the notification-secrets branch from 94c54ba to 3c2a8e7 Compare October 16, 2023 16:25
@mmattel
Copy link
Contributor

mmattel commented Oct 16, 2023

Q:
tab1=master, tab2=currently v4, tab3=currently v3
does this change apply to v3 too?
in case not, we can manage this, though this will be no problem when we release v5 😄

@case0sh case0sh force-pushed the notification-secrets branch from 3c2a8e7 to 76f8e83 Compare October 16, 2023 17:54
@mmattel
Copy link
Contributor

mmattel commented Oct 17, 2023

@case0sh thanks for taking care about the versions possible, but we should do this differerntly. I will do a commit to show you which makes maintenance life more easy.

@case0sh case0sh mentioned this pull request Oct 17, 2023
Merged
11 tasks
@mmattel mmattel changed the title notification secrets Helmchart notification secrets Oct 17, 2023
@mmattel
Copy link
Contributor

mmattel commented Oct 17, 2023 •
edited
Loading

@case0sh
The commit I just added is a bit more than expected, though the change directly related to the PR was small. When working on the commit I saw, that some attributes used are no longer needed as we already have three ocis releases. This is now cleaned up. The relation to this PR is, that we now have a clean structure, similar as we use in new services, rendering tabs on demand for a given version. When there is a new Helm Chart release that has allows to render prepared content, we can now just use attributes for the tab block related. I have added comments in the text to explain easing life for upcoming changes.

Note: from my pov, if there are no more content changes, we can remove draft and go on.

@case0sh case0sh marked this pull request as ready for review October 17, 2023 12:08
@mmattel mmattel merged commit 7b2169d into master Oct 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the notification-secrets branch October 17, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@case0sh @mmattel