Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special Scope Environment Variables #335

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Special Scope Environment Variables #335

merged 1 commit into from
Dec 28, 2022

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Dec 20, 2022

This PR adds a page covering environment variables with a special scope.

  • Variables with extended scope do not directly configure services but functions underneath.
  • Variables with a global scope can configure more than one service.

The page and the required stuff around in the documentation is ready, but the content coming from the ocis repo which gets included not. Extended scope vars are already available but the file needs renaming and the CI an update. The progarm that creates the table for global scope vars needs to be made.

Note that for the time being, the global envvar stuff has been commented out as the data is currently not available. When available, it is only a matter of uncommenting to make it visible.

Keeping this PR therefore as draft to avoid accidentially merging.

A language review for my comments is always welcomed.

Currently visible on staging.

@kobergj fyi

@mmattel mmattel added the documentation Improvements or additions to documentation label Dec 20, 2022
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The English looks OK. A person more familiar with the technical details can review the technical content.

@mmattel mmattel force-pushed the global_scope_envvars branch 3 times, most recently from aa12e80 to 75d098e Compare December 28, 2022 10:27
@mmattel mmattel force-pushed the global_scope_envvars branch from b1f6867 to 95f5c40 Compare December 28, 2022 10:35
@mmattel mmattel marked this pull request as ready for review December 28, 2022 15:08
@mmattel
Copy link
Contributor Author

mmattel commented Dec 28, 2022

The extended evnvvar adoc file has been backported in the ocis repo, we can merge now.

@mmattel mmattel merged commit 5fca842 into master Dec 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the global_scope_envvars branch December 28, 2022 15:11
@mmattel
Copy link
Contributor Author

mmattel commented Feb 8, 2023

Just for reference: owncloud/ocis#3917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants