Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onProgress callback #39

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Add onProgress callback #39

merged 1 commit into from
Oct 15, 2019

Conversation

PVince81
Copy link
Contributor

No description provided.

@PVince81 PVince81 mentioned this pull request Oct 14, 2019
Merged
@DeepDiver1975
Copy link
Member

Travis needs love ....

@PVince81
Copy link
Contributor Author

currently still draft. I want to test this with the code that actually uses this.

then I'll move forward to make this mergable

@PVince81 PVince81 mentioned this pull request Oct 14, 2019
Merged
22 tasks
@PVince81
Copy link
Contributor Author

@DeepDiver1975 Travis fix here: #40

@PVince81 PVince81 marked this pull request as ready for review October 15, 2019 13:42
@PVince81
Copy link
Contributor Author

rebased for Travis fixes

@PVince81
Copy link
Contributor Author

Fixed. I mistakenly used ES6 syntax.

@PVince81 PVince81 merged commit 7354b63 into master Oct 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-progress branch October 15, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PVince81 @DeepDiver1975