Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] update issue tag for the failing scenario in oCIS CI #40418

Merged
merged 1 commit into from
Oct 13, 2022
Merged

[tests-only] update issue tag for the failing scenario in oCIS CI #40418

merged 1 commit into from
Oct 13, 2022

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Oct 12, 2022 •
edited
Loading

Description

This pr just adds an issue tag for the failing scenario in oCIS due to the related issue (see below)

Related Issue

@kiranparajuli589 kiranparajuli589 self-assigned this Oct 12, 2022
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiWebdavOperations-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/36992/84

@kiranparajuli589 kiranparajuli589 changed the title [tests-only] split report response check for oCIS and oC10 environments [tests-only] update issue tag for the failing scenario in oCIS CI Oct 13, 2022
saw-jan
saw-jan reviewed Oct 13, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

phil-davis
phil-davis approved these changes Oct 13, 2022
View reviewed changes
tests/acceptance/features/bootstrap/WebDav.php
@@ -5373,7 +5373,7 @@ public function findEntryFromPropfindResponse(
$entryPath = $multistatusResult['value'][0]['value'];
if (OcisHelper::isTestingOnOcis() && $method === "REPORT") {
if ($entryNameToSearch !== null && str_ends_with($entryPath, $entryNameToSearch)) {
return $multistatusResults;
return $multistatusResult;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this PR also fixes a bug here. It seems that there are not any tests that really rely on this line of code (at least not for oC10), because it was passing before and is still passing now.

@phil-davis phil-davis merged commit 3048fd4 into master Oct 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-multistatus branch October 13, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@phil-davis phil-davis phil-davis approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closed issue spaces endpoint does not allow REPORT requests still exist in expected-to-failure
5 participants
@kiranparajuli589 @ownclouders @phil-davis @saw-jan @amrita-shrestha