Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only[full-ci] Skip admin operation related tests in reva #40414

Merged
merged 2 commits into from
Oct 11, 2022
Merged

[tests-only[full-ci] Skip admin operation related tests in reva #40414

merged 2 commits into from
Oct 11, 2022

Conversation

SwikritiT
Copy link
Contributor

Description

This PR skips a test in reva which creates folder as admin user and since reva uses ldap there's no pre-defined admin user there. Furthermore this test was added specifically for a issue in ocis owncloud/ocis#4671

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SwikritiT SwikritiT self-assigned this Oct 11, 2022
SagarGi
SagarGi reviewed Oct 11, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT merged commit 65806c1 into master Oct 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the skip-tests-only-in-reva branch October 11, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SwikritiT @individual-it @SagarGi