[tests-only]Fix tests related to the identical received shares #40393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💥 Acceptance tests pipeline apiProxySmoke-8-3-mariadb10.2-php7.4 failed. The build has been cancelled. |
SwikritiT
force-pushed
the
refactor-identical-share-test-code-for-ocis
branch
from
67dee09 to
3505a4b
Compare
SwikritiT
force-pushed
the
refactor-identical-share-test-code-for-ocis
branch
from
5cc0971 to
e81dfd4
Compare
SwikritiT
changed the title
SwikritiT
commented
Oct 17, 2022
...s/acceptance/features/apiShareCreateSpecialToRoot1/createShareReceivedInMultipleWays.feature
Show resolved
Hide resolved
SwikritiT
commented
Oct 17, 2022
| @@ -2092,7 +2092,7 @@ public function checkElementList( | |||
| "//d:response/d:href[text() = \"$webdavPath\"]" | |||
| ); | |||
| if ($expectedToBeListed | |||
| && (!isset($element[0]) || $element[0]->__toString() !== $webdavPath) | |||
| && (!isset($element[0]) || urldecode($element[0]->__toString()) !== urldecode($webdavPath)) | |||
There was a problem hiding this comment.
decoded here as suggested by owncloud/ocis#4676 (comment)
SwikritiT
requested review from
SagarGi,
kiranparajuli589 and
amrita-shrestha
SwikritiT
changed the title
tests/acceptance/features/apiShareCreateSpecialToShares1/createShareUniqueReceivedNames.feature
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
saw-jan
reviewed
Oct 18, 2022
tests/acceptance/features/apiShareManagementToShares/acceptShares.feature
Outdated
Show resolved
Hide resolved
SwikritiT
force-pushed
the
refactor-identical-share-test-code-for-ocis
branch
from
634142f to
211f0b7
Compare
SwikritiT
force-pushed
the
refactor-identical-share-test-code-for-ocis
branch
from
211f0b7 to
63c2f17
Compare
grgprarup
reviewed
Oct 19, 2022
tests/acceptance/features/apiShareManagementToShares/acceptShares.feature
Show resolved
Hide resolved
|
All the tests are passing in full-ci expect the |
SwikritiT
changed the title
SwikritiT
force-pushed
the
refactor-identical-share-test-code-for-ocis
branch
from
63c2f17 to
72e2cea
Compare
phil-davis
approved these changes
Oct 21, 2022
tests/acceptance/features/apiShareManagementToShares/acceptShares.feature
Show resolved
Hide resolved
delete-merged-branch
bot
deleted the
refactor-identical-share-test-code-for-ocis
branch
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: