Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Handle 425 'too early' on oCIS and reva #40180

Merged
merged 1 commit into from
Jul 7, 2022
Merged

[full-ci] [tests-only] Handle 425 'too early' on oCIS and reva #40180

merged 1 commit into from
Jul 7, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 6, 2022 •
edited
Loading

Description

Allow API requests to return HTTP status 425 "too early" on oCIS and reva. In that case, retry the request after a 1-second wait. Allow up to 10 retries, giving the server-under-test a reasonable chance to finish whatever background post-processing it is doing.

Related Issue

Part of owncloud/ocis#4095

How Has This Been Tested?

CI passes here and in reva cs3org/reva#3034
So at least there is no regression in the test results.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Jul 6, 2022
@phil-davis phil-davis mentioned this pull request Jul 6, 2022
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis marked this pull request as ready for review July 6, 2022 13:21
@phil-davis phil-davis mentioned this pull request Jul 6, 2022
Closed
@individual-it individual-it mentioned this pull request Jul 7, 2022
Closed
kiranparajuli589
kiranparajuli589 approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@phil-davis
Copy link
Contributor Author

Let's merge this, and @kobergj can report back on how it helps, and if there are other tweaks that would be useful.

@phil-davis phil-davis merged commit f1e0bf0 into master Jul 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the ocis-4095 branch July 7, 2022 08:37
This was referenced Jul 7, 2022
Merged
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 approved these changes

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@phil-davis phil-davis

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @kiranparajuli589