Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci][tests-only] Improve then steps for suite 'apiFederationToShares2' #40007

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

kiranparajuli589
Copy link
Contributor

Description

Improve then steps for acceptance tests suite apiFederationToShares2

Related Issue

@kiranparajuli589 kiranparajuli589 self-assigned this Apr 22, 2022
@kiranparajuli589 kiranparajuli589 force-pushed the improve-then-steps-in-api-fed-to-shares-two branch from 023069e to 00b5a5e Compare April 22, 2022 08:39
@phil-davis
Copy link
Contributor

@kiranparajuli589 needs a rebase:
Conflicting files
tests/acceptance/features/bootstrap/WebDav.php

A few other testing PRs have been merged today.

@kiranparajuli589
Copy link
Contributor Author

@kiranparajuli589 needs a rebase: Conflicting files tests/acceptance/features/bootstrap/WebDav.php

A few other testing PRs have been merged today.

💯 fixed it PhilJI

@ownclouders
Copy link
Contributor

ownclouders commented Apr 22, 2022

💥 Acceptance tests pipeline apiProxySmoke-8-2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/35402/175

@kiranparajuli589 kiranparajuli589 marked this pull request as draft April 22, 2022 09:33
@kiranparajuli589 kiranparajuli589 changed the title [tests-only] Improve then steps for suite 'apiFederationToShares2' [full-ci][tests-only] Improve then steps for suite 'apiFederationToShares2' Apr 22, 2022
@kiranparajuli589 kiranparajuli589 force-pushed the improve-then-steps-in-api-fed-to-shares-two branch 2 times, most recently from d00533c to 5717e84 Compare April 22, 2022 12:27
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review April 22, 2022 12:27
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can put a comment for the OCS status code where notset is cheked as it is asserted so that it could be more clear what notset is for others. Others LGTM.

@kiranparajuli589 kiranparajuli589 marked this pull request as draft April 25, 2022 04:09
@kiranparajuli589 kiranparajuli589 force-pushed the improve-then-steps-in-api-fed-to-shares-two branch 2 times, most recently from 78c6350 to 29b4d57 Compare April 25, 2022 11:29
@kiranparajuli589 kiranparajuli589 marked this pull request as ready for review April 25, 2022 11:49
@kiranparajuli589 kiranparajuli589 force-pushed the improve-then-steps-in-api-fed-to-shares-two branch 2 times, most recently from 7897d8f to ce2a224 Compare April 26, 2022 09:04
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes.

Signed-off-by: Parajuli Kiran <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kiranparajuli589 kiranparajuli589 merged commit 1e3adb2 into master Apr 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-then-steps-in-api-fed-to-shares-two branch April 26, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants