Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Improve then steps usages inside acceptance tests suite apiFederationToRoot2 #40004

Merged
merged 1 commit into from
May 3, 2022
Merged

[tests-only][full-ci]Improve then steps usages inside acceptance tests suite apiFederationToRoot2 #40004

merged 1 commit into from
May 3, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Apr 22, 2022

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suites covered:

  • apiFederationToRoot2

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi mentioned this pull request Apr 22, 2022
Closed
@SagarGi SagarGi self-assigned this Apr 25, 2022
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiFederationToRoot2 branch 7 times, most recently from 7b26133 to dd92270 Compare April 28, 2022 09:43
@SagarGi SagarGi marked this pull request as ready for review April 28, 2022 09:44
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiFederationToRoot2 branch 2 times, most recently from bfe09e9 to 1a4a054 Compare April 28, 2022 10:34
@SagarGi SagarGi requested a review from amrita-shrestha April 28, 2022 10:35
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiFederationToRoot2 branch from 1a4a054 to c39e4d5 Compare April 29, 2022 07:00
kiranparajuli589
kiranparajuli589 reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@grgprarup
Copy link
Contributor

@SagarGi In some scenarios, this And using server "LOCAL" step is used before checking status codes and somewhere after checking status codes. Why not make uniform in all scenarios?
@kiranparajuli589 Any suggestions?

@SagarGi
Copy link
Member Author

SagarGi commented Apr 30, 2022

@SagarGi In some scenarios, this And using server "LOCAL" step is used before checking status codes and somewhere after checking status codes. Why not make uniform in all scenarios? @kiranparajuli589 Any suggestions?

@grgprarup can be made before the status check. i will do it.

amrita-shrestha
amrita-shrestha reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amrita-shrestha amrita-shrestha requested a review from phil-davis May 3, 2022 03:43
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiFederationToRoot2 branch from c39e4d5 to 6f8d313 Compare May 3, 2022 04:18
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 4ee9352 into master May 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-then-steps-in-apiFederationToRoot2 branch May 3, 2022 05:24
This was referenced May 3, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 approved these changes

@phil-davis phil-davis phil-davis approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@grgprarup grgprarup Awaiting requested review from grgprarup

@sushmita56 sushmita56 Awaiting requested review from sushmita56

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SagarGi @grgprarup @phil-davis @kiranparajuli589 @amrita-shrestha