Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Improve then steps usages inside acceptance tests suite apiFederationToRoot1 #39986

Merged
merged 1 commit into from
Apr 25, 2022
Merged

[tests-only][full-ci]Improve then steps usages inside acceptance tests suite apiFederationToRoot1 #39986

merged 1 commit into from
Apr 25, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Apr 20, 2022

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suites covered:

  • apiFederationToRoot1

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi mentioned this pull request Apr 20, 2022
Closed
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiFederationToRoot1 branch 2 times, most recently from 3ad996a to e35f31b Compare April 21, 2022 10:52
@SagarGi SagarGi marked this pull request as ready for review April 22, 2022 03:35
@SagarGi SagarGi self-assigned this Apr 22, 2022
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiFederationToRoot1 branch from e35f31b to 22ebf70 Compare April 22, 2022 07:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kiranparajuli589
kiranparajuli589 reviewed Apr 22, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

SwikritiT
SwikritiT reviewed Apr 25, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarGi SagarGi requested a review from phil-davis April 25, 2022 06:58
@phil-davis phil-davis merged commit a78fccd into master Apr 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-then-steps-in-apiFederationToRoot1 branch April 25, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@grgprarup grgprarup Awaiting requested review from grgprarup

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SagarGi @phil-davis @kiranparajuli589 @SwikritiT