Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the width of the form on login page #39962

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Limit the width of the form on login page #39962

merged 1 commit into from
Apr 7, 2022

Conversation

ChrisEdS
Copy link
Contributor

@ChrisEdS ChrisEdS commented Apr 7, 2022 •
edited
Loading

Description

The login form breaks if error messages and info messages are longer.

Related Issue

How Has This Been Tested?

  • Manually tested

Screenshots:

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ChrisEdS ChrisEdS self-assigned this Apr 7, 2022
@update-docs
Copy link

update-docs bot commented Apr 7, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

AlexAndBear
AlexAndBear suggested changes Apr 7, 2022
View reviewed changes
Copy link

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog item

@ChrisEdS ChrisEdS force-pushed the fix-login-form-width branch from 697e188 to 2e567f4 Compare April 7, 2022 12:48
@ChrisEdS ChrisEdS requested a review from AlexAndBear April 7, 2022 12:48
@ownclouders
Copy link
Contributor

ownclouders commented Apr 7, 2022 •
edited
Loading

💥 Acceptance tests pipeline apiWebdavLocks-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/35243/88

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit 21f1ee4 into master Apr 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-login-form-width branch April 7, 2022 15:02
@jnweiger
Copy link
Contributor

Confirmed fixed in 10.10.0 RC2

@ChrisEdS ChrisEdS mentioned this pull request May 13, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@ChrisEdS ChrisEdS

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Long text breaks the login form width
5 participants
@ChrisEdS @ownclouders @jnweiger @phil-davis @AlexAndBear