Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Improve then steps in apiShareCreateSpecialToShares1 suite #39938

Merged
merged 1 commit into from
Apr 13, 2022
Merged

[tests-only][full-ci]Improve then steps in apiShareCreateSpecialToShares1 suite #39938

merged 1 commit into from
Apr 13, 2022

Conversation

sushmita56
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suite Covered

  • apiShareCreateSpecialToShare1

Related Issues

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sushmita56 sushmita56 marked this pull request as draft April 1, 2022 11:07
@sushmita56 sushmita56 force-pushed the then-steps-in-apiShareCreateSpecialToShares1 branch 2 times, most recently from c0b382a to b9dafb3 Compare April 11, 2022 11:18
@sushmita56 sushmita56 marked this pull request as ready for review April 11, 2022 11:19
@kiranparajuli589
Copy link
Contributor

lint failed. try make test-php-style

@sushmita56 sushmita56 force-pushed the then-steps-in-apiShareCreateSpecialToShares1 branch from b9dafb3 to eac5034 Compare April 12, 2022 03:24
@sushmita56 sushmita56 force-pushed the then-steps-in-apiShareCreateSpecialToShares1 branch from eac5034 to a8e4c01 Compare April 12, 2022 03:52
@sushmita56 sushmita56 requested a review from SwikritiT April 12, 2022 04:16
@sushmita56 sushmita56 force-pushed the then-steps-in-apiShareCreateSpecialToShares1 branch from a8e4c01 to 4dc7804 Compare April 12, 2022 09:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sushmita56 sushmita56 requested a review from SagarGi April 12, 2022 10:18
kiranparajuli589
kiranparajuli589 reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sushmita56 sushmita56 requested a review from phil-davis April 12, 2022 11:05
SagarGi
SagarGi reviewed Apr 13, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sushmita56 sushmita56 requested review from individual-it and removed request for phil-davis April 13, 2022 08:08
@individual-it individual-it merged commit 9bee19f into master Apr 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the then-steps-in-apiShareCreateSpecialToShares1 branch April 13, 2022 08:15
@sushmita56 sushmita56 mentioned this pull request Apr 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@individual-it individual-it individual-it approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@sushmita56 sushmita56

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sushmita56 @kiranparajuli589 @individual-it @SwikritiT @SagarGi