Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Improve then steps usages inside acceptance tests suite apiTags #39921

Merged
merged 1 commit into from
Mar 25, 2022
Merged

[tests-only][full-ci]Improve then steps usages inside acceptance tests suite apiTags #39921

merged 1 commit into from
Mar 25, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Mar 24, 2022

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suites covered:

  • apiTags

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi marked this pull request as draft March 24, 2022 10:11
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiTags branch from e951bb0 to 6d16705 Compare March 24, 2022 10:12
@SagarGi SagarGi mentioned this pull request Mar 24, 2022
Closed
@SagarGi SagarGi marked this pull request as ready for review March 24, 2022 11:01
@SagarGi SagarGi self-assigned this Mar 24, 2022
amrita-shrestha
amrita-shrestha reviewed Mar 24, 2022
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiranparajuli589 kiranparajuli589 changed the title I[tests-only][full-ci]Add then step to suites apiTags I[tests-only][full-ci]Improve then steps usages inside acceptance tests suite apiTags Mar 24, 2022
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiTags branch from 6d16705 to 702643a Compare March 25, 2022 03:23
@sonarcloud
Copy link

sonarcloud bot commented Mar 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kiranparajuli589 kiranparajuli589 changed the title I[tests-only][full-ci]Improve then steps usages inside acceptance tests suite apiTags [tests-only][full-ci]Improve then steps usages inside acceptance tests suite apiTags Mar 25, 2022
kiranparajuli589
kiranparajuli589 reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@SagarGi SagarGi requested a review from individual-it March 25, 2022 06:05
@individual-it individual-it merged commit df1a1eb into master Mar 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-then-steps-in-apiTags branch March 25, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@individual-it individual-it individual-it approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SagarGi @individual-it @kiranparajuli589 @amrita-shrestha