Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]added then steps for apiProvisioningGroups-v1 suite #39840

Merged
merged 1 commit into from
Mar 10, 2022
Merged

[tests-only][full-ci]added then steps for apiProvisioningGroups-v1 suite #39840

merged 1 commit into from
Mar 10, 2022

Conversation

sushmita56
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suite Covered

  • apiProvisioningGroups-v1

Related Issues

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sushmita56 sushmita56 self-assigned this Mar 1, 2022
@sushmita56 sushmita56 mentioned this pull request Mar 1, 2022
Closed
@sushmita56 sushmita56 changed the title added then steps for apiProvisioningGroups-v1 suite [tests-only][full-ci]added then steps for apiProvisioningGroups-v1 suite Mar 1, 2022
@sushmita56 sushmita56 removed the QA:team label Mar 1, 2022
@sushmita56 sushmita56 marked this pull request as draft March 1, 2022 11:25
@sushmita56 sushmita56 force-pushed the then-steps-in-apiProvisioningGroups-v1 branch from 9403e47 to fe44e6d Compare March 2, 2022 04:25
@sushmita56 sushmita56 marked this pull request as ready for review March 2, 2022 05:54
@sushmita56 sushmita56 marked this pull request as draft March 2, 2022 05:57
@kiranparajuli589 kiranparajuli589 removed their request for review March 2, 2022 06:32
@grgprarup grgprarup removed the request for review from phil-davis March 2, 2022 06:42
@grgprarup grgprarup removed the QA:team label Mar 2, 2022
@sushmita56 sushmita56 force-pushed the then-steps-in-apiProvisioningGroups-v1 branch from fe44e6d to cda6c2a Compare March 3, 2022 10:56
@sushmita56 sushmita56 marked this pull request as ready for review March 3, 2022 10:59
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

kiranparajuli589
kiranparajuli589 reviewed Mar 3, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@kiranparajuli589
Copy link
Contributor

kiranparajuli589 commented Mar 7, 2022 •
edited
Loading

imo @grgprarup @sushmita56 feature indentations can be fixed separately. here is a ticket for reminder #39852

@owncloud owncloud deleted a comment from update-docs bot Mar 8, 2022
@sushmita56 sushmita56 requested a review from grgprarup March 10, 2022 03:25
@phil-davis phil-davis merged commit 986d520 into master Mar 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the then-steps-in-apiProvisioningGroups-v1 branch March 10, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@sushmita56 sushmita56

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sushmita56 @kiranparajuli589 @phil-davis @grgprarup