Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add then step to suites apiWebdavMove(1 and 2) #39835

Merged
merged 2 commits into from
Mar 4, 2022
Merged

[tests-only][full-ci]Add then step to suites apiWebdavMove(1 and 2) #39835

merged 2 commits into from
Mar 4, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Feb 28, 2022

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suites covered:

  • apiWebdavMove1
  • apiWebdavMove2

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi self-assigned this Feb 28, 2022
@SagarGi SagarGi mentioned this pull request Feb 28, 2022
Closed
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiWebdavMove branch from 9f97430 to e96cbf6 Compare March 1, 2022 06:13
@SagarGi SagarGi marked this pull request as ready for review March 1, 2022 07:19
saw-jan
saw-jan reviewed Mar 1, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kiranparajuli589
kiranparajuli589 reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@SagarGi SagarGi force-pushed the improve-then-steps-in-apiWebdavMove branch from e96cbf6 to 05682eb Compare March 3, 2022 11:08
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiWebdavMove branch from 05682eb to d66b2ba Compare March 4, 2022 03:21
@sonarcloud
Copy link

sonarcloud bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it individual-it merged commit 4fb8f37 into master Mar 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-then-steps-in-apiWebdavMove branch March 4, 2022 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 approved these changes

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

@grgprarup grgprarup Awaiting requested review from grgprarup

@sushmita56 sushmita56 Awaiting requested review from sushmita56

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SagarGi @individual-it @kiranparajuli589 @saw-jan