Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]added then steps for apiMain suite #39828

Merged
merged 1 commit into from
Feb 28, 2022
Merged

[tests-only][full-ci]added then steps for apiMain suite #39828

merged 1 commit into from
Feb 28, 2022

Conversation

sushmita56
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suite Covered

  • apiMain

Related Issues

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sushmita56 sushmita56 marked this pull request as draft February 24, 2022 10:35
@sushmita56 sushmita56 self-assigned this Feb 25, 2022
@phil-davis
Copy link
Contributor

@sushmita56 are you finished? Is this ready?

@sushmita56 sushmita56 marked this pull request as ready for review February 28, 2022 03:25
@sushmita56
Copy link
Contributor Author

Yes, it is.

@grgprarup grgprarup mentioned this pull request Feb 28, 2022
Closed
@grgprarup grgprarup self-requested a review February 28, 2022 06:14
@sushmita56 sushmita56 force-pushed the then-steps-in-apiMain branch from bf93d0c to 3031900 Compare February 28, 2022 07:19
@sushmita56 sushmita56 force-pushed the then-steps-in-apiMain branch from 3031900 to 72c072f Compare February 28, 2022 08:35
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kiranparajuli589 kiranparajuli589 merged commit 8280751 into master Feb 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the then-steps-in-apiMain branch February 28, 2022 10:13
@sushmita56 sushmita56 mentioned this pull request Mar 1, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 approved these changes

@individual-it individual-it Awaiting requested review from individual-it

@grgprarup grgprarup Awaiting requested review from grgprarup

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@sushmita56 sushmita56

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sushmita56 @phil-davis @kiranparajuli589