Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add then step to suite apiWebdavOperations #39826

Merged
merged 1 commit into from
Feb 28, 2022
Merged

[tests-only][full-ci]Add then step to suite apiWebdavOperations #39826

merged 1 commit into from
Feb 28, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Feb 24, 2022

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suites covered:

  • apiWebdavOperations

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi mentioned this pull request Feb 24, 2022
Closed
@SagarGi SagarGi marked this pull request as ready for review February 24, 2022 09:00
@SagarGi SagarGi self-assigned this Feb 24, 2022
@sushmita56 sushmita56 marked this pull request as draft February 24, 2022 10:34
@SagarGi SagarGi marked this pull request as ready for review February 24, 2022 10:51
@SagarGi SagarGi force-pushed the improve-then-steps-in-apiWebdavOperations branch from 8f1841e to 7e5b2cf Compare February 28, 2022 06:14
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

phil-davis
phil-davis approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit 554186c into master Feb 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-then-steps-in-apiWebdavOperations branch February 28, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SagarGi @phil-davis @kiranparajuli589