Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] Added Then steps to improve checks in tests for apiFavorites suite #39811

Merged
merged 1 commit into from
Feb 22, 2022
Merged

[tests-only] [full-ci] Added Then steps to improve checks in tests for apiFavorites suite #39811

merged 1 commit into from
Feb 22, 2022

Conversation

grgprarup
Copy link
Contributor

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suites covered:

  • apiFavorites

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@grgprarup grgprarup self-assigned this Feb 21, 2022
@grgprarup grgprarup mentioned this pull request Feb 21, 2022
Closed
@grgprarup grgprarup marked this pull request as ready for review February 21, 2022 09:23
@grgprarup grgprarup changed the title [tests-only] [full-ci] Added Then steps to improve checks in tests for apiFavorites suite [tests-only] [full-ci] Added Then steps to improve checks in tests for apiFavorites suite Feb 21, 2022
kiranparajuli589
kiranparajuli589 reviewed Feb 21, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

SwikritiT
SwikritiT reviewed Feb 22, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grgprarup grgprarup force-pushed the improve-then-steps-in-apiFavorites branch from a312f7c to 261ac05 Compare February 22, 2022 04:06
saw-jan
saw-jan reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amrita-shrestha
amrita-shrestha reviewed Feb 22, 2022
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SagarGi
SagarGi reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit cb07663 into master Feb 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-then-steps-in-apiFavorites branch February 22, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@saw-jan saw-jan saw-jan left review comments

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 approved these changes

@phil-davis phil-davis phil-davis approved these changes

@sushmita56 sushmita56 Awaiting requested review from sushmita56

@Talank Talank Awaiting requested review from Talank

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@grgprarup @phil-davis @kiranparajuli589 @SwikritiT @SagarGi @saw-jan @amrita-shrestha