Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] Added Then steps to improve checks in tests for apiComments suite #39794

Merged
merged 1 commit into from
Feb 17, 2022
Merged

[tests-only] [full-ci] Added Then steps to improve checks in tests for apiComments suite #39794

merged 1 commit into from
Feb 17, 2022

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Feb 15, 2022 •
edited by sushmita56
Loading

Description

This PR adds Then steps to existing API test scenarios to better check the results of When steps.

Suites covered:

  • apiCapabilities
  • apiComments

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@grgprarup grgprarup changed the title [tests-only] [full-ci] Improved checks in tests for apiComments suite [tests-only] [full-ci] Added Then steps to improve checks in tests for apiComments suite Feb 15, 2022
@grgprarup grgprarup force-pushed the improve-then-steps-in-api-acceptance-tests branch 2 times, most recently from 150e239 to 147c189 Compare February 16, 2022 03:06
@grgprarup grgprarup marked this pull request as ready for review February 16, 2022 04:53
@kiranparajuli589 kiranparajuli589 mentioned this pull request Feb 16, 2022
Closed
kiranparajuli589
kiranparajuli589 reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 please squash your commits before merge.

@grgprarup grgprarup force-pushed the improve-then-steps-in-api-acceptance-tests branch from 526671b to d487a0a Compare February 16, 2022 05:06
phil-davis
phil-davis previously approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are going to be annoying for expected-failures updates. So we will need to be good at updating expected-failures very regularly to minimize the pain.

@phil-davis phil-davis self-requested a review February 16, 2022 05:41
@phil-davis phil-davis dismissed their stale review February 16, 2022 05:42

I missed one small problem that Amrita noticed.

@grgprarup grgprarup force-pushed the improve-then-steps-in-api-acceptance-tests branch from d487a0a to 0fa2616 Compare February 16, 2022 11:47
@kiranparajuli589
Copy link
Contributor

failed at /drone/src/tests/acceptance/features/webUIUpload/upload.feature:131
https://drone.owncloud.com/owncloud/core/34667/151/17

build restarted

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kiranparajuli589 kiranparajuli589 merged commit 62aed7f into owncloud:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@saw-jan saw-jan Awaiting requested review from saw-jan

@Talank Talank Awaiting requested review from Talank

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grgprarup @kiranparajuli589 @phil-davis @amrita-shrestha