Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] update getPersonalSpaceIdForUser to use new oc:id format #39793

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 15, 2022

Description

This PR makes the code more flexible in getPersonalSpaceIdForUser. It auto-detects if the space id is in base64-encoded format (the current "old" format) or in the proposed new unencoded format. So the tests will run auto-magically against cs3org/reva with either the old or proposed new format without needing to do anything special in CI.

This provides a way to transition to the proposed new format without breaking any CI.

Related Issue

reva PR cs3org/reva#2542

How Has This Been Tested?

CI
cs3org/reva#2550 - CI passes in reva master branch using the code here in this PR.
cs3org/reva#2551 - CI passes in reva edge branch using the code here in this PR.
cs3org/reva#2552 - CI passes in reva edge with the proposed "remove base64 encoding of ids" code from cs3org/reva#2542

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis force-pushed the update-getPersonalSpaceIdForUser branch from b8e7eb9 to 10f3f9a Compare February 15, 2022 15:24
@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis marked this pull request as ready for review February 16, 2022 15:39
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@phil-davis
Copy link
Contributor Author

@micbar this code works with both versions of the space id. We could merge this to core, and then you can test and merge the space-id changes in reva whenever you like, without CI breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants