Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add spaces tests for apiWebdavMove2 suite #39774

Merged
merged 1 commit into from
Feb 11, 2022
Merged

[tests-only][full-ci]Add spaces tests for apiWebdavMove2 suite #39774

merged 1 commit into from
Feb 11, 2022

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Feb 9, 2022 •
edited
Loading

Description

adds spaces DAV path on apiWebdavMove2 suite

  • moves two test scenario related to moving folder from apiWebdavMove2/moveFile.feature to apiWebdavMove1/moveFolder.feature
  • adds new feature file moveShareOnOcisfile for testing Share related test only on ocis

Related Issue

How Has This Been Tested?

  • Locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require an increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@kiranparajuli589
Copy link
Contributor

approved accidentally...sorry for the inconvenience!

kiranparajuli589
kiranparajuli589 previously requested changes Feb 9, 2022
View reviewed changes
@amrita-shrestha amrita-shrestha force-pushed the spaces-on-apiWebdavMove2 branch from bdd6ecd to 60cdb79 Compare February 10, 2022 12:33
@amrita-shrestha amrita-shrestha mentioned this pull request Feb 10, 2022
Merged
5 tasks
@amrita-shrestha amrita-shrestha force-pushed the spaces-on-apiWebdavMove2 branch from 60cdb79 to ce97d9f Compare February 10, 2022 17:15
kiranparajuli589
kiranparajuli589 reviewed Feb 11, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also mention the reasons behind adding a new feature file moveShareOnOcis.feature

@amrita-shrestha amrita-shrestha force-pushed the spaces-on-apiWebdavMove2 branch 3 times, most recently from b446a5c to a0aaa10 Compare February 11, 2022 08:33
@amrita-shrestha amrita-shrestha force-pushed the spaces-on-apiWebdavMove2 branch from a0aaa10 to 736aeac Compare February 11, 2022 08:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amrita-shrestha amrita-shrestha marked this pull request as ready for review February 11, 2022 09:23
kiranparajuli589
kiranparajuli589 reviewed Feb 11, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@kiranparajuli589 kiranparajuli589 dismissed their stale review February 11, 2022 09:46

suggested changes have been made.

@phil-davis phil-davis merged commit b338530 into master Feb 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the spaces-on-apiWebdavMove2 branch February 11, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update apiWebdavMove2 suite for spaces webdav
3 participants
@amrita-shrestha @kiranparajuli589 @phil-davis