Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] use spaces dav path in apiAuth suite #39712

Merged
merged 1 commit into from
Jan 25, 2022
Merged

[tests-only] use spaces dav path in apiAuth suite #39712

merged 1 commit into from
Jan 25, 2022

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Jan 24, 2022 •
edited
Loading

Description

use spaces DAV path in apiAuth suite

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@kiranparajuli589 kiranparajuli589 changed the title [tests-only] use spaces dav path in apiMain suite [tests-only] use spaces dav path in apiAuth suite Jan 24, 2022
@kiranparajuli589 kiranparajuli589 mentioned this pull request Jan 24, 2022
Closed
@kiranparajuli589 kiranparajuli589 self-assigned this Jan 24, 2022
@amrita-shrestha
Copy link
Contributor

LGTM

SwikritiT
SwikritiT reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than already mentioned

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 5a1c148 into master Jan 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the spaces-api-main branch January 25, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@phil-davis phil-davis phil-davis approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use spaces webdav for apiAuth suite
4 participants
@kiranparajuli589 @amrita-shrestha @phil-davis @SwikritiT